Allow require reason on storage changes#128
Open
XingY wants to merge 2 commits into
Open
Conversation
cnathe
approved these changes
Jun 25, 2026
cnathe
left a comment
cnathe
left a comment
Contributor
There was a problem hiding this comment.
CR and testing complete. Looks good. As mentioned, you can revert a couple of those version updates and get this merged. I will open a new PR with the version bump after the unrelated Rlabkey PR is also merged.
Comment on lines
+21
to
+22
| Version: \tab 3.4.X\cr | ||
| Date: \tab 2026-X\cr |
Contributor
There was a problem hiding this comment.
you can revert this and just leave them as-is for now. I am waiting on one other Rlabkey package change so will open a new PR to bump the version after these both are in
Comment on lines
+2
to
+3
| Version: 3.4.X | ||
| Date: 2026-X |
Contributor
There was a problem hiding this comment.
same here, you can revert this and leave them as-is
| @@ -1,3 +1,7 @@ | |||
| Changes in 3.4.7 | |||
Contributor
There was a problem hiding this comment.
you can just put this as 3.X and I will update it with my next PR after this is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Related Pull Requests
Changes
labkey.storage.deleteto acceptauditUserCommentparamauditUserComment