-
Notifications
You must be signed in to change notification settings - Fork 9
Allow require reason on storage changes #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| Changes in 3.4.7 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can just put this as 3.X and I will update it with my next PR after this is merged. |
||
| o Pass auditUserComment to labkey.storage.delete for attaching a reason to the audit log record | ||
| o labkey.storage.create and labkey.storage.update now accept an optional auditUserComment entry inside the props list (recorded as the "Reason" on the resulting audit event) | ||
|
|
||
| Changes in 3.4.6 | ||
| o Incorporate new filter types for Array (Multi-value text choice) fields | ||
| o Update listToMatrix to handle cases where the list elements are an array of strings, which will return a comma separated string in the response | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,8 +18,8 @@ schema objects (\code{labkey.getSchema}). | |
| \tabular{ll}{ | ||
| Package: \tab Rlabkey\cr | ||
| Type: \tab Package\cr | ||
| Version: \tab 3.4.6\cr | ||
| Date: \tab 2026-02-17\cr | ||
| Version: \tab 3.4.X\cr | ||
| Date: \tab 2026-X\cr | ||
|
Comment on lines
+21
to
+22
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can revert this and just leave them as-is for now. I am waiting on one other Rlabkey package change so will open a new PR to bump the version after these both are in |
||
| License: \tab Apache License 2.0\cr | ||
| LazyLoad: \tab yes\cr | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, you can revert this and leave them as-is