Apply ABI Breaking Changes to KMeans Params (release branch)#2329
Open
tarang-jain wants to merge 9 commits into
Open
Apply ABI Breaking Changes to KMeans Params (release branch)#2329tarang-jain wants to merge 9 commits into
tarang-jain wants to merge 9 commits into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
tarang-jain
added
breaking
tarang-jain
marked this pull request as ready for review
July 20, 2026 22:04
rapids-bot Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
This PR renames the `streaming_batch_size` param for kmeans to: 1. Better convey the meaning of the param -- link to discussion: #2323 (comment) 2. Avoid confusion with the already existing `batch_samples` and `batch_centroids` params The idea is that the `streaming` word can be misleading. We are "buffering up" a batch of samples onto the device. Merge after #2329 Authors: - Tarang Jain (https://github.com/tarang-jain) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #2328
cjnolet
approved these changes
Jul 24, 2026
Contributor
Author
|
/ok to test ddc7040 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an exact copy of #2147 but targeted to the release branch