CFG Part 1: ProcDecoder Refactor#2596
Closed
ike709 wants to merge 18 commits into
Closed
Conversation
boring-cyborg
Bot
added
Compiler
Collaborator
Author
|
We could eliminate the |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public sealed class BytecodeProcDecoder(IReadOnlyList<string> strings, byte[] bytecode) { | ||
| public readonly IReadOnlyList<string> Strings = strings; | ||
| public readonly byte[] Bytecode = bytecode; | ||
| public int Offset = 0; |
Collaborator
Author
|
Will update after #2635 is merged. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Collaborator
Author
|
Superceded by #2651 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please merge #2635 first since this PR is branched off of that. This PR is just the last couple commits.EDIT: Will update after #2635 is merged first.This is the much more atomized next PR in the series of changes to implement a control flow graph. This PR focuses on ripping ProcDecoder out of the runtime and throwing it into the DMCompiler project so the control flow graph can share it with the debugger and disassembler. It also changes the
ITupleto a newProcInstructionstruct comprised ofProcOperands.I tested it by doing before & after disassembler dumps of TG between CFG Part 0 and this PR. They were identical except for the removal of some trailing whitespace on some of the
N-variant opcodes.