CFG Part 0 Slim Edition: ProcDecoder fixes#2635
Merged
Merged
Conversation
This was referenced Jun 22, 2026
wixoaGit
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was revealed to me in a dream that I could avoid clogging up the CFG with internally-generated dead blocks by simply flagging and ignoring them instead of overcomplicating codegen and trying to make it perfect at the cost of simplicity and performance as seen in the previous PR. Dealing with those dead blocks will come when the CFG actually ships. The max stack changes will also be split off into their own separate PR without the other expensive peephole optimizer changes.
Instead, this PR is just some of the minimum amount of prerequisite changes necessary to get the CFG working, which is some fixes to ProcDecoder for missing/incorrect opcodes. It is still the precursor to CFG Part 1 and should be merged prior to that PR.
It would be nice if we could prevent these sorts of issues but I'll leave that for a future PR.