Upgrade Pester to version 6#2194
Open
liamjpeters wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repo’s tooling, CI, and test suite to be compatible with (and pinned to) Pester v6, addressing Windows PowerShell CI failures caused by the removal of the -Pending parameter.
Changes:
- Pinned Pester to
6.0.1in tooling (installPSResources.ps1) and Windows PowerShell CI (ci-test.yml). - Migrated affected Pester tests from
-Pendingto-Skipfor v6 compatibility. - Updated README references to Pester v6 / minimum required Pester version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/installPSResources.ps1 | Bumps the pinned Pester version used by tooling installs to 6.0.1. |
| Tests/Rules/UseToExportFieldsInManifest.tests.ps1 | Replaces -Pending usage with -Skip for Pester v6 compatibility. |
| Tests/Rules/UseIdenticalMandatoryParametersForDSC.tests.ps1 | Replaces -Pending usage with -Skip for Pester v6 compatibility. |
| README.md | Updates documentation to reference Pester v6 and minimum required version. |
| .github/workflows/ci-test.yml | Pins Pester version in Windows PowerShell CI to avoid unintentional upgrades. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Windows PowerShell CI tests were not pinned to a Pester version and so used the latest stable. This changed recently to v6 (well done on the release @nohwnd 🎉).
Windows PowerShell CI was broken - complaining of a missing
-Pendingparameter, which has been removed in v6.Instead of just pinning the Windows PowerShell version to 5.7.1, the changes required for v6 compatibility were minimal, so those changes were made instead.
Claude and I used the v5-v6 migration guide and skill to update to v6.
I've now pinned the Windows PowerShell version in line with the
tools/installPSResources.ps1version - settling on the current6.0.1. I Can't find a tidy way to specify the version once and have it used in both places. Open to suggestions if there's a good way.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.