Skip to content

Upgrade Pester to version 6 #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liamjpeters wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade Pester to version 6 #2194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- name: Test Windows PowerShell
if: matrix.os == 'windows-latest'
run: |
Install-Module Pester -Scope CurrentUser -Force -SkipPublisherCheck
Install-Module Pester -RequiredVersion 6.0.1 -Scope CurrentUser -Force -SkipPublisherCheck
./build.ps1 -Test -Verbose
shell: powershell

Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ To install **PSScriptAnalyzer** from source code:
- If building for Windows PowerShell versions, then the .NET Framework 4.6.2 [targeting pack](https://dotnet.microsoft.com/en-us/download/dotnet-framework/net462) (also referred to as developer/targeting pack) need to be installed. This is only possible on Windows.
- Optional but recommended for development: [Visual Studio 2022](https://www.visualstudio.com/downloads)
- Or [Visual Studio Code](https://code.visualstudio.com/download)
- [Pester v5 PowerShell module, available on PowerShell Gallery](https://github.com/pester/Pester)
- [Pester v6 PowerShell module, available on PowerShell Gallery](https://github.com/pester/Pester)
Comment thread
liamjpeters marked this conversation as resolved.
- [PlatyPS PowerShell module, available on PowerShell Gallery](https://github.com/PowerShell/platyPS/releases)

### Steps
Expand Down Expand Up @@ -154,7 +154,7 @@ built-in rules.

Pester-based ScriptAnalyzer Tests are located in `path/to/PSScriptAnalyzer/Tests` folder.

- Ensure [Pester](https://www.powershellgallery.com/packages/Pester) of at least version 5.3 is installed
- Ensure [Pester](https://www.powershellgallery.com/packages/Pester) of at least version 6.0 is installed
- In the root folder of your local repository, run:

```powershell
Expand Down
2 changes: 1 addition & 1 deletion Tests/Rules/UseIdenticalMandatoryParametersForDSC.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Describe "UseIdenticalMandatoryParametersForDSC" {
}

# todo add a test to check one violation per function
It "Should find a violations" -pending {
It "Should find a violations" -Skip {
Comment thread
liamjpeters marked this conversation as resolved.
$violations.Count | Should -Be 0
}
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/Rules/UseToExportFieldsInManifest.tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ Describe "UseManifestExportFields" {
$results[0].Extent.Text | Should -Be "'*'"
}

It "suggests corrections for AliasesToExport with wildcard" -pending:($IsCoreClr) {
It "suggests corrections for AliasesToExport with wildcard" -Skip:($IsCoreClr) {
$violations = Run-PSScriptAnalyzerRule $testManifestBadAliasesWildcardPath
$violationFilepath = Join-path $testManifestPath $testManifestBadAliasesWildcardPath
Test-CorrectionExtent $violationFilepath $violations[0] 1 "'*'" "@('gbar', 'gfoo')"
Expand Down
2 changes: 1 addition & 1 deletion tools/installPSResources.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Install-PSResource -Verbose -TrustRepository -RequiredResource @{
repository = $PSRepository
}
Pester = @{
version = "5.7.1"
version = "6.0.1"
repository = $PSRepository
}
}