CASSNODEJS-14: Multiple Node Status Updates - All but One being Dropped - #471
Open
toptobes wants to merge 1 commit into
Open
CASSNODEJS-14: Multiple Node Status Updates - All but One being Dropped#471toptobes wants to merge 1 commit into
toptobes wants to merge 1 commit into
Conversation
SiyaoIsHiding
left a comment
SiyaoIsHiding
left a comment
Contributor
There was a problem hiding this comment.
Code changes make sense me. Would be great if we have tests!
| // Waits a couple of seconds before marking it as UP | ||
| self._nodeStatusChangeTimeout = setTimeout(() => host.checkIsUp(), newNodeDelay); | ||
| self._nodeStatusChangeTimers.set(endPoint, setTimeout(() => { | ||
| self._nodeStatusChangeTimers.delete(endPoint); |
Contributor
There was a problem hiding this comment.
nit: do we need this line here?
self._nodeStatusChangeTimers.delete(endPoint);
Author
There was a problem hiding this comment.
I mean, technically no? But there's not much point keeping dead timer ids around even if they'll be overwritten anyway, it's mostly a minor memory thing.
SiyaoIsHiding
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
ControlConnection._nodeStatusChangeTimeoutto be a map of hosts => timers instead so that if multiple nodes had status updates at the same time, it wouldn't lead to all but one being dropped/ignored, which should speed up recovery time in such cases nowThe node status event handlers may look different in the future under an all-encompassing "events handling overhaul", but this is a pretty simple fix for the time being