Skip to content

CASSNODEJS-14: Multiple Node Status Updates - All but One being Dropped #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toptobes wants to merge 1 commit into
base: trunk
Choose a base branch
from
+17 −5
Open

CASSNODEJS-14: Multiple Node Status Updates - All but One being Dropped #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions lib/control-connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ class ControlConnection extends events.EventEmitter {

// Timeout used for delayed handling of topology changes
this._topologyChangeTimeout = null;
// Timeout used for delayed handling of node status changes
this._nodeStatusChangeTimeout = null;
// Map of host endpoint strings to their pending status change timeouts
this._nodeStatusChangeTimers = new Map();

if (context && context.borrowHostConnection) {
this._borrowHostConnection = context.borrowHostConnection;
Expand Down Expand Up @@ -598,14 +598,23 @@ class ControlConnection extends events.EventEmitter {
self.log('warning', 'Received status change event but host was not found: ' + addressToTranslate);
return;
}

const existingTimer = self._nodeStatusChangeTimers.get(endPoint);
if (existingTimer) {
clearTimeout(existingTimer);
self._nodeStatusChangeTimers.delete(endPoint);
}

const distance = self._profileManager.getDistance(host);
if (event.up) {
if (distance === types.distance.ignored) {
return host.setUp(true);
}
clearTimeout(self._nodeStatusChangeTimeout);
// Waits a couple of seconds before marking it as UP
self._nodeStatusChangeTimeout = setTimeout(() => host.checkIsUp(), newNodeDelay);
self._nodeStatusChangeTimers.set(endPoint, setTimeout(() => {
self._nodeStatusChangeTimers.delete(endPoint);

@SiyaoIsHiding SiyaoIsHiding Jul 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do we need this line here?

self._nodeStatusChangeTimers.delete(endPoint);

@toptobes toptobes Jul 29, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, technically no? But there's not much point keeping dead timer ids around even if they'll be overwritten anyway, it's mostly a minor memory thing.

host.checkIsUp();
}, newNodeDelay));
return;
}
// marked as down
Expand Down Expand Up @@ -998,7 +1007,10 @@ class ControlConnection extends events.EventEmitter {
this.emit('newConnection', new errors.DriverError('ControlConnection is being shutdown'));
// Cancel timers
clearTimeout(this._topologyChangeTimeout);
clearTimeout(this._nodeStatusChangeTimeout);
for (const timer of this._nodeStatusChangeTimers.values()) {
clearTimeout(timer);
}
this._nodeStatusChangeTimers.clear();
}

/**
Expand Down
Loading