fix(dataZoom): keep slider handle label visible when mouse stays over handle after drag end - #21722
Open
waterWang wants to merge 1 commit into
Open
Conversation
… handle after drag end
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20178
Problem
When dragging a dataZoom slider handle and releasing the mouse without moving it away (i.e. the mouse stays over the handle), the handle's label disappears even though the pointer is still over the handle.
Root cause
During a drag, the handle's
onmouseoutcan fire (the pointer briefly leaves the handle hit area as it moves), which setsSliderZoomView._isOverDataInfoTriggerArea = false. Ondragend,_onDragEnd()checks that flag and, because it isfalse, calls_showDataInfo(false)which hides the label — even though the mouse is still sitting over the handle.Fix
Accept the
dragendevent in_onDragEnd(e). When the flag isfalse, only hide the label if the drag did not end on a handle or the move zone. If the drag released over a handle / move zone, keep the label visible so it matches the "mouse is still over the handle" expectation.This also forwards the event from
_onActualMoveZoneDragEndso the move-zone drag path behaves the same way.