Skip to content

fix(dataZoom): keep slider handle label visible when mouse stays over handle after drag end #21722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −3
Open

fix(dataZoom): keep slider handle label visible when mouse stays over handle after drag end #21722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/component/dataZoom/SliderZoomView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@ class SliderZoomView extends DataZoomView {

private _onActualMoveZoneDragEnd(event: ZRElementEvent) {
(event.target as Displayable).attr('cursor', 'grab');
this._onDragEnd();
this._onDragEnd(event);
}

private _onDragMove(handleIndex: 0 | 1 | 'all', dx: number, dy: number, event: ZRElementEvent) {
Expand All @@ -952,12 +952,23 @@ class SliderZoomView extends DataZoomView {
changed && realtime && this._dispatchZoomAction(true);
}

private _onDragEnd() {
private _onDragEnd(e?: ZRElementEvent) {
this._dragging = false;

if (!this._isOverDataInfoTriggerArea) {
// Drag end may occur on draggable bars, where data info should be still shown.
this._showDataInfo(false);
// When the drag ends, if the mouse is still over a handle or the move zone
// (e.g. the user releases without moving the mouse away), keep the label visible.
// This prevents the label from disappearing after a drag-and-release where
// the mouse stays over the handle (mouseout may have fired during drag).
const target = e && e.target;
const displayables = this._displayables;
const isOverDraggable = target === displayables.handles[0]
|| target === displayables.handles[1]
|| target === displayables.moveZone;
if (!isOverDraggable) {
this._showDataInfo(false);
}
}

// While in realtime mode and stream mode, dispatch action when
Expand Down