fix(model-trainer): correct sagemaker_config Networking defaults - #6145
Open
saisharan0103 wants to merge 1 commit into
Open
Conversation
…in `ModelTrainer` Closes aws#5766
saisharan0103
requested a deployment
to
manual-approval
August 1, 2026 20:11 — with
GitHub Actions
Waiting
saisharan0103
requested a deployment
to
manual-approval
August 1, 2026 20:11 — with
GitHub Actions
Waiting
saisharan0103
requested a deployment
to
manual-approval
August 1, 2026 20:11 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #5766 reports
sagemaker_configrelatedNetworkingbugs inModelTrainer.Root cause:
Networkingconfig fromsagemaker_config.Networkingobject, it used the non-existentdefault_enable_network_isolationkeyword instead ofenable_network_isolation, which Pydantic rejects as an extra field.Networkingobject with missingsecurity_group_ids, it assigned thesubnetsfield from the subnets config path instead of assigningsecurity_group_idsfromTRAINING_JOB_SECURITY_GROUP_IDS_PATH, silently dropping the security group defaults.Changes:
Networkingwithenable_network_isolation.security_group_idsfromTRAINING_JOB_SECURITY_GROUP_IDS_PATH.Networkingfromsagemaker_configand for filling missingsecurity_group_idson an existingNetworkingobject while preserving existing subnets.Files modified:
sagemaker-train/tests/unit/train/test_model_trainer.pyLOC: +3 / -0
ruff check sagemaker-train/tests/unit/train/test_model_trainer.pyreports no new findings on the changed files.Ran
pytest -xlocally with no new failures.