Skip to content

fix(model-trainer): correct sagemaker_config Networking defaults #6145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saisharan0103 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(model-trainer): correct sagemaker_config Networking defaults #6145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sagemaker-train/tests/unit/train/test_model_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1959,6 +1959,9 @@ def test_networking_intelligent_defaults_creates_networking(model_trainer):
assert model_trainer.networking.enable_network_isolation is True
assert model_trainer.networking.subnets == NETWORKING_DEFAULT_SUBNETS
assert model_trainer.networking.security_group_ids == NETWORKING_DEFAULT_SECURITY_GROUP_IDS
model_trainer.config_mgr.resolve_value_from_config.assert_any_call(
config_path=TRAINING_JOB_SECURITY_GROUP_IDS_PATH
)


def test_networking_intelligent_defaults_no_vpc_config_leaves_networking_unset(model_trainer):
Expand Down
Loading