chore(deps): bump inquirerer to 4.9.3 (paste + idle-timeout fixes) - #1650
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up dev-utils#104 across all 10 workspace packages that depend on the inquirerer family:
inquirerer^4.9.1 → ^4.9.3,@inquirerer/utils^3.3.9 → ^3.3.11,@inquirerer/test^1.4.3 → ^1.4.5.4.9.3 fixes two library defects that affect every CLI we ship, not just the one that reported them:
TerminalKeypressdropped any stdin chunk carrying more than one keypress (paste, fast typing), because it looked the whole chunk up as one exact key while text prompts register one listener per character. Symptom: silently truncated input — a pasted password fails auth with a misleading error — and an ignored Ctrl-C when it shared a chunk.!noTty), so it killed people typing at a real terminal and never fired for the non-interactive CI case it was written for.Consequence for the in-flight #1642 (
agent login): the local workarounds it carries —agentic/cli/src/keypress-chunks.ts, which monkey-patches the privateprompter.keypress.dataHandler, and thenew Inquirerer({ timeout: 0x7fffffff })escape hatch — are now redundant and should be deleted on that branch or in a follow-up once it lands.genomic@5.6.2still pinsinquirerer@4.9.1transitively, so both versions remain in the lockfile; that resolves when genomic is bumped.Link to Devin session: https://app.devin.ai/sessions/783ae9ff63b445879450d5051d9d3d83
Requested by: @pyramation