Allow bench workflow to run on PRs from forks#688
Open
ashkrisk wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
(Manually adding the PR checklist for now) Before you submit for review:
If you did not complete any of these, then please explain below.
|
Contributor
Author
|
The default bench dataset is changed back to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows all CI workflows to run correctly on PRs from forks. This mainly applies to the workflow which runs AutoBenchYAML.
github.head.ref(fork-workflow-2) withgithub.ref(/refs/pull/688/merge). The checkout action fails for the former if the branch is from a fork, but the latter works in both cases.pull_request_targetworkflow rather thepull_requestworkflow. This allows the bot to add the PR checklist to PRs from forks. You'll notice that the bot did not comment on this PR, despite this change; this is becausepull_request_targetworkflows are executed based on definitions in the main branch rather than the PR branch (for security reasons). This should work correctly on fork PRs raised after this PR is merged.