feat: local relay - #3068
Merged
Merged
Conversation
paul-nechifor
requested review from
leshy,
mustafab0 and
spomichter
as code owners
July 20, 2026 16:11
paul-nechifor
marked this pull request as draft
July 20, 2026 16:11
Contributor
Greptile SummaryThis PR adds a local relay for robot telemetry and viewer connections. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (6): Last reviewed commit: "fix(tests): scope the relay-kill e2e tes..." | Re-trigger Greptile |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #3068 +/- ##
==========================================
+ Coverage 74.09% 74.33% +0.24%
==========================================
Files 1103 1108 +5
Lines 104077 105309 +1232
Branches 9520 9598 +78
==========================================
+ Hits 77114 78283 +1169
- Misses 24270 24316 +46
- Partials 2693 2710 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
paul-nechifor
force-pushed
the
paul/feat/web-4-e2e-packaging
branch
from
July 23, 2026 12:07
aef5a79 to
c412753
Compare
paul-nechifor
force-pushed
the
paul/feat/t2-relay
branch
from
July 23, 2026 12:46
6159287 to
ddd01e3
Compare
paul-nechifor
force-pushed
the
paul/feat/web-4-e2e-packaging
branch
2 times, most recently
from
July 24, 2026 03:18
da42793 to
3994661
Compare
paul-nechifor
force-pushed
the
paul/feat/t2-relay
branch
2 times, most recently
from
July 24, 2026 12:15
fb898c9 to
efb16dc
Compare
paul-nechifor
force-pushed
the
paul/feat/web-4-e2e-packaging
branch
from
July 24, 2026 20:23
3994661 to
4b1a0ae
Compare
paul-nechifor
force-pushed
the
paul/feat/t2-relay
branch
2 times, most recently
from
July 26, 2026 02:03
31cc330 to
d596a73
Compare
paul-nechifor
marked this pull request as ready for review
July 26, 2026 02:23
paul-nechifor
force-pushed
the
paul/feat/t2-relay
branch
from
July 26, 2026 03:42
d596a73 to
f9935dd
Compare
paul-nechifor
force-pushed
the
paul/feat/t2-relay
branch
from
July 26, 2026 04:23
f9935dd to
e45ae1e
Compare
Installing libturbojpeg on the regular CI runners (for the relay bridge tests) armed the previously-dormant jpeg case in test_codecs.py: with the native lib present, _jpeg_case() no longer bailed out early and downloaded go2_short.db (84 MB) from LFS at collection time, which the git-lfs-guard on regular runners blocks, failing collection. Resolve the cases at test time through an indirect fixture instead, and mark the jpeg case self_hosted so the download only happens where big LFS pulls are allowed (self-hosted runners and local machines). The cheap turbojpeg availability probe stays at collection time so the case is still silently absent (not a skip) where turbojpeg is missing, matching the old behavior under --error-for-skips.
test_relay_child_death_respawns_and_recovers kills the shared module-scoped bridge's relay child; the respawned child's pipe-reader threads are created mid-test and legitimately live until module teardown, so the per-test thread-leak monitor flags them. This mostly went unnoticed because the monitor keys on thread idents and the new readers usually recycle the just-joined old readers' idents, dodging the check by luck; when scheduling breaks the reuse (seen on the arm64 CI runner) the test errors at teardown. Give the destructive test its own function-scoped bridge so the respawned child dies inside the test scope, and move the stop_module helper (Module.stop + executor reap) into e2e_support for both test files to share.
paul-nechifor
enabled auto-merge
July 27, 2026 09:49
leshy
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--local-relayto spawn a local relay.server.tsinto smaller files.RelayBridgeModule.dimos runautomatically addsRelayBridgeModuleif--local-relayis specified.How to Test
Run:
Go to http://127.0.0.1:45175/debug.html .
Run sim:
Go to http://127.0.0.1:7780/debug.html
Closes DIM-1164