Add assertion handler to all LCM unit tests via lm_cc_test macro #378
+160
−24
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| load("@rules_cc//cc:defs.bzl", "cc_library") | ||
|
|
||
| cc_library( | ||
| name = "testing_assertion_handler", | ||
| testonly = True, | ||
| srcs = ["assertion_handler.cpp"], | ||
| hdrs = ["assertion_handler.hpp"], | ||
| include_prefix = "score/mw/launch_manager/testing", | ||
| strip_include_prefix = "/score/launch_manager/src/testing", | ||
| visibility = ["//score/launch_manager:__subpackages__"], | ||
| deps = ["@score_baselibs//score/language/futurecpp"], | ||
| alwayslink = True, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /******************************************************************************** | ||
| * Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| * | ||
| * See the NOTICE file(s) distributed with this work for additional | ||
| * information regarding copyright ownership. | ||
| * | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Apache License Version 2.0 which is available at | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| ********************************************************************************/ | ||
|
|
||
| #include "score/mw/launch_manager/testing/assertion_handler.hpp" | ||
|
|
||
| namespace | ||
| { | ||
|
|
||
| // Registers the assertion handler at static-initialization time so every unit | ||
| // test binary that links this library gets diagnostic output on assertion failure | ||
| // without any explicit setup call. | ||
| const bool kAssertionHandlerRegistered = []() noexcept { | ||
| score::lcm::testing::registerAssertionHandler(); | ||
| return true; | ||
| }(); | ||
|
|
||
| } // namespace |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /******************************************************************************** | ||
| * Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| * | ||
| * See the NOTICE file(s) distributed with this work for additional | ||
| * information regarding copyright ownership. | ||
| * | ||
| * This program and the accompanying materials are made available under the | ||
| * terms of the Apache License Version 2.0 which is available at | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| ********************************************************************************/ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <score/assert.hpp> | ||
|
|
||
| #include <iostream> | ||
| #include <sstream> | ||
|
|
||
| namespace score::lcm::testing | ||
| { | ||
|
|
||
| inline void registerAssertionHandler() noexcept | ||
|
Contributor
There was a problem hiding this comment. I think we can use the same assertion handler for the daemon as tests. Would move this maybe into |
||
| { | ||
| score::cpp::set_assertion_handler([](const score::cpp::handler_parameters& params) { | ||
| std::ostringstream msg; | ||
| msg << "Assertion failed: " << (params.condition != nullptr ? params.condition : "") | ||
| << "\n Location: " << (params.file != nullptr ? params.file : "?") << ":" << params.line | ||
| << " (" << (params.function != nullptr ? params.function : "?") << ")"; | ||
| if (params.message != nullptr) | ||
| { | ||
| msg << "\n Message: " << params.message; | ||
| } | ||
| msg << "\n"; | ||
| std::cerr << msg.str(); | ||
| }); | ||
| } | ||
|
|
||
| } // namespace score::lcm::testing | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
| """Bazel macros for LCM unit tests.""" | ||
|
|
||
| load("@rules_cc//cc:defs.bzl", "cc_test") | ||
|
|
||
| def lm_cc_test(name, deps = [], **kwargs): | ||
| """Wrapper around cc_test that auto-registers the LCM assertion handler. | ||
|
|
||
| All arguments are forwarded to cc_test unchanged. The assertion handler | ||
| library is injected so that assertion failures in any unit test binary | ||
| print a diagnostic message before aborting, without requiring any | ||
| explicit setup call in test code. | ||
|
|
||
| Args: | ||
| name: Test target name. | ||
| deps: Additional dependencies (assertion handler is appended automatically). | ||
| **kwargs: Forwarded verbatim to cc_test. | ||
| """ | ||
| cc_test( | ||
| name = name, | ||
| deps = deps + ["//score/launch_manager/src/testing:testing_assertion_handler"], | ||
| **kwargs | ||
| ) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everywhere else we use
#ifdefsso please change this.