robustness: follow up change for #21806

[henrybear327]

No description provided.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.22%. Comparing base (8ad92a0) to head (6b563cb).

Additional details and impacted files

see 19 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #21808   +/-   ##
=======================================
  Coverage   70.21%   70.22%           
=======================================
  Files         427      427           
  Lines       35304    35304           
=======================================
+ Hits        24788    24791    +3     
+ Misses       9125     9122    -3     
  Partials     1391     1391           

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad92a0...6b563cb. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[k8s-ci-robot]

@henrybear327: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-verify	6b563cb	link	true	/test pull-etcd-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[serathius]

Please fix, recommend not to use if err := ...; err != nil {

../tests/robustness/main_test.go:98:6: shadow: declaration of "err" shadows declaration at line 91 (govet)
		if err := r.Finalize(t.Failed(), panicked); err != nil {
		   ^
../tests/robustness/main_test.go:104:5: shadow: declaration of "err" shadows declaration at line 91 (govet)
	if err := r.SaveEtcdData(); err != nil {
	   ^
2 issues:
* govet: 2

[serathius]

What about saving visualization?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment