chore: prep 1.1.2#3345
Conversation
|
Warning Review limit reached
More reviews will be available in 25 minutes and 35 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. 📝 WalkthroughWalkthroughThe pull request consolidates maintenance and release management updates: CHANGELOG.md is reorganized to introduce a v1.2.0 section and place the P2P pubsub fix under versioned tracking, an internal constants file is removed as cleanup, and a sequencer test loop is updated to use modern Go range syntax. ChangesMaintenance and Release Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @julienrbrt's task in 1m 21s —— View job Code Review: chore: prep 1.1.2
SummaryThis is a small, clean release-prep PR. Changes are well-scoped and low-risk. A couple of minor issues are worth fixing before tagging the release. CHANGELOG.mdGood:
Issues: Line 16 — spelling errors (pre-existing, but published in this release): Fix this → - - Add max bytes contraints in simple solo sequnecer [#3312](...)
+ - Add max bytes constraints in simple solo sequencer [#3312](...)These will be permanently etched in the changelog once tagged — worth a one-liner fix. Line 28 — trailing period after PR link: Minor style inconsistency. Other entries in - - Increase P2P pubsub max message size to match `DefaultMaxBlobSize`, preventing fullnode desync on large blocks [#3344](https://github.com/evstack/ev-node/pull/3344).
+ - Increase P2P pubsub max message size to match `DefaultMaxBlobSize`, preventing fullnode desync on large blocks [#3344](https://github.com/evstack/ev-node/pull/3344)block/internal/common/consts.go (deleted)Safe. The file contained only pkg/sequencers/solo/sequencer_test.go// Before
for i := 0; i < 10; i++ {
// After
for range 10 {Correct modernization to Go 1.22+ range-over-integer syntax. No behavior change, cleaner signal that VerdictApproved with two optional CHANGELOG fixes (the typos are the more important of the two). No logic changes, no security surface, no concurrency concerns — pure housekeeping. |
|
The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
CHANGELOG.md (1)
16-16:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix spelling errors.
Two typos detected:
- "contraints" → "constraints"
- "sequnecer" → "sequencer"
📝 Proposed fix
-- Add max bytes contraints in simple solo sequnecer [`#3312`](https://github.com/evstack/ev-node/pull/3312) +- Add max bytes constraints in simple solo sequencer [`#3312`](https://github.com/evstack/ev-node/pull/3312)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@CHANGELOG.md` at line 16, Fix the two spelling typos in the CHANGELOG entry: replace "contraints" with "constraints" and "sequnecer" with "sequencer" in the line that currently reads "Add max bytes contraints in simple solo sequnecer [`#3312`](https://github.com/evstack/ev-node/pull/3312)"; ensure the corrected line reads "Add max bytes constraints in simple solo sequencer [`#3312`](https://github.com/evstack/ev-node/pull/3312)".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 28: Update the changelog line "Increase P2P pubsub max message size to
match `DefaultMaxBlobSize`, preventing fullnode desync on large blocks" to
include the missing PR reference in the same format used elsewhere (e.g. add "
[`#NNNN`](URL)") so the Fixed entry matches other entries for traceability; locate
and edit that exact sentence in CHANGELOG.md and append the PR link.
---
Outside diff comments:
In `@CHANGELOG.md`:
- Line 16: Fix the two spelling typos in the CHANGELOG entry: replace
"contraints" with "constraints" and "sequnecer" with "sequencer" in the line
that currently reads "Add max bytes contraints in simple solo sequnecer
[`#3312`](https://github.com/evstack/ev-node/pull/3312)"; ensure the corrected
line reads "Add max bytes constraints in simple solo sequencer
[`#3312`](https://github.com/evstack/ev-node/pull/3312)".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 86038962-6f94-49f4-ba70-d19fc3d3f6be
📒 Files selected for processing (3)
CHANGELOG.mdblock/internal/common/consts.gopkg/sequencers/solo/sequencer_test.go
💤 Files with no reviewable changes (1)
- block/internal/common/consts.go
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3345 +/- ##
==========================================
- Coverage 60.73% 60.70% -0.03%
==========================================
Files 127 127
Lines 13781 13781
==========================================
- Hits 8370 8366 -4
- Misses 4499 4502 +3
- Partials 912 913 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
Overview
Prep ev-node v1.1.2
Summary by CodeRabbit