Skip to content

[pigeon] Clean up legacy registrant code#12205

Open
stuartmorgan-g wants to merge 3 commits into
flutter:mainfrom
stuartmorgan-g:pigeon-example-registrant-cleanup
Open

[pigeon] Clean up legacy registrant code#12205
stuartmorgan-g wants to merge 3 commits into
flutter:mainfrom
stuartmorgan-g:pigeon-example-registrant-cleanup

Conversation

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Now that the new APIs are available on stable, remove the view controller subclass workaround and use the standard scene-friendly registration system for channel code.

Now that the new APIs are available on stable, remove the view
controller subclass workaround and use the standard scene-friendly
registration system for channel code.
@stuartmorgan-g stuartmorgan-g added override: no changelog needed Override the check requiring CHANGELOG updates for most changes CICD Run CI/CD labels Jul 15, 2026
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator Author

You'll want to apply these changes to your new example copy in your PR.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the iOS runner example in Pigeon to adopt FlutterImplicitEngineDelegate on AppDelegate instead of using a custom ExampleViewController subclass. It also updates the storyboard to use FlutterViewController directly. The review feedback points out an unused controller variable in AppDelegate.swift that can be safely removed.

Comment thread packages/pigeon/example/app/ios/Runner/AppDelegate.swift Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: pigeon platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant