[file_selector] Switch to Swift Testing#12235
Open
stuartmorgan-g wants to merge 2 commits into
Open
Conversation
Updates the iOS and macOS Swift unit tests to use Swift Testing rather than XCTest. Part of flutter/flutter#180787
19 tasks
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the iOS and macOS example runner tests for the file selector plugins from XCTest to the Swift Testing framework, replacing test classes, assertions, and expectations with @Suite, @Test, #expect, and confirmation. The review feedback recommends utilizing try #require(...) to safely unwrap optionals instead of force-unwrapping or using conditional binding, and simplifying array assertions to avoid potential out-of-bounds errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the iOS and macOS Swift unit tests to use Swift Testing rather than XCTest.
Part of flutter/flutter#180787
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2