Skip to content

[file_selector] Switch to Swift Testing #12235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stuartmorgan-g wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[file_selector] Switch to Swift Testing #12235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21754bc
[file_selector] Switch to Swift Testing
stuartmorgan-g Jul 17, 2026
e4c98fc
GCA review
stuartmorgan-g Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 38 additions & 38 deletions packages/file_selector/file_selector_ios/example/ios/RunnerTests/FileSelectorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// found in the LICENSE file.

import Flutter
import XCTest
import Testing

@testable import file_selector_ios

Expand All @@ -25,8 +25,8 @@ final class StubViewPresenterProvider: ViewPresenterProvider {
}
}

class FileSelectorTests: XCTestCase {
func testPickerPresents() throws {
@Suite @MainActor struct FileSelectorTests {
@Test func pickerPresents() throws {
let presenter = TestViewPresenter()
let plugin = FileSelectorPlugin(
viewPresenterProvider: StubViewPresenterProvider(viewPresenter: presenter))
Expand All @@ -37,58 +37,58 @@ class FileSelectorTests: XCTestCase {
config: FileSelectorConfig(utis: [], allowMultiSelection: false)
) { _ in }

XCTAssertEqual(plugin.pendingCompletions.count, 1)
XCTAssertTrue(picker.delegate === plugin.pendingCompletions.first)
XCTAssertTrue(presenter.presentedController === picker)
#expect(plugin.pendingCompletions.count == 1)
#expect(picker.delegate === plugin.pendingCompletions.first)
#expect(presenter.presentedController === picker)
}

func testReturnsPickedFiles() throws {
@Test func returnsPickedFiles() async throws {
let plugin = FileSelectorPlugin(
viewPresenterProvider: StubViewPresenterProvider(viewPresenter: TestViewPresenter()))
let picker = UIDocumentPickerViewController(documentTypes: [], in: UIDocumentPickerMode.import)
plugin.documentPickerViewControllerOverride = picker
let completionWasCalled = expectation(description: "completion")

plugin.openFile(
config: FileSelectorConfig(utis: [], allowMultiSelection: false)
) { result in
switch result {
case .success(let paths):
XCTAssertEqual(paths, ["/file1.txt", "/file2.txt"])
case .failure(let error):
XCTFail("\(error)")
try await confirmation("completion") { completionWasCalled in
plugin.openFile(
config: FileSelectorConfig(utis: [], allowMultiSelection: false)
) { result in
switch result {
case .success(let paths):
#expect(paths == ["/file1.txt", "/file2.txt"])
case .failure(let error):
Issue.record("\(error)")
}
completionWasCalled()
}
completionWasCalled.fulfill()
let pendingCompletion = try #require(plugin.pendingCompletions.first)
pendingCompletion.documentPicker(
picker,
didPickDocumentsAt: [URL(string: "file:///file1.txt")!, URL(string: "file:///file2.txt")!])
}
plugin.pendingCompletions.first!.documentPicker(
picker,
didPickDocumentsAt: [URL(string: "file:///file1.txt")!, URL(string: "file:///file2.txt")!])

waitForExpectations(timeout: 30.0)
XCTAssertTrue(plugin.pendingCompletions.isEmpty)
#expect(plugin.pendingCompletions.isEmpty)
}

func testCancellingPickerReturnsEmptyList() throws {
@Test func cancellingPickerReturnsEmptyList() async throws {
let plugin = FileSelectorPlugin(
viewPresenterProvider: StubViewPresenterProvider(viewPresenter: TestViewPresenter()))
let picker = UIDocumentPickerViewController(documentTypes: [], in: UIDocumentPickerMode.import)
plugin.documentPickerViewControllerOverride = picker
let completionWasCalled = expectation(description: "completion")

plugin.openFile(
config: FileSelectorConfig(utis: [], allowMultiSelection: false)
) { result in
switch result {
case .success(let paths):
XCTAssertEqual(paths.count, 0)
case .failure(let error):
XCTFail("\(error)")
try await confirmation("completion") { completionWasCalled in
plugin.openFile(
config: FileSelectorConfig(utis: [], allowMultiSelection: false)
) { result in
switch result {
case .success(let paths):
#expect(paths.count == 0)
case .failure(let error):
Issue.record("\(error)")
}
completionWasCalled()
}
completionWasCalled.fulfill()
let pendingCompletion = try #require(plugin.pendingCompletions.first)
pendingCompletion.documentPickerWasCancelled(picker)
}
plugin.pendingCompletions.first!.documentPickerWasCancelled(picker)

waitForExpectations(timeout: 30.0)
XCTAssertTrue(plugin.pendingCompletions.isEmpty)
#expect(plugin.pendingCompletions.isEmpty)
}
}
Loading
Loading