fix(hero): describe the real cover height instead of "full page" - #134
Merged
Conversation
The hero docs promised a "full-page hero" and a "full-height hero" for `cover: true`. A cover section is 88vh, capped at 1024px from the xxl breakpoint upwards, so both claims overstated it and left readers treating the deliberate 12vh peek as a bug. State the actual height, explain why it falls short of the viewport, and point at the `main.sectionHeight` and `main.maxSectionHeight` settings that change it. Also correct the illustrated-hero paragraph: `cover` keeps a tall illustration inside its column rather than stretching it, and leaves landscape illustrations alone. Refs: gethinode/hinode#2107 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 2, 2026
Contributor
Author
|
🎉 This PR is included in version 1.15.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the fix for gethinode/hinode#2107, where a user reported
cover: trueas a bug because the docs promised more than the theme delivers.Problem
Two claims in
content/blocks/hero.mdoverstatedcover:coverto true to display a full-page hero."coverto true to display a full-height hero."A cover section is 88vh, capped at 1024px from
xxlupwards. The deliberate 12vh peek reads as a bug when the docs say "full page".Change
main.sectionHeight/main.maxSectionHeight.coverdoes not stretch the illustration — it keeps a tall one inside its column so it can't push the hero past the cover height, and leaves landscape images alone (their width is already the limiting dimension underobject-fit: contain). Verified by measurement, not by reading the SCSS.The config link uses an absolute
https://gethinode.com/...URL, matchingcontent/components/image.md:130— a root-relative link fails Hinode's internal link validation when these pages render in the Hinode exampleSite, which the build caught.Typed
fixrather thandocsso it releases and gethinode.com can pick it up.Builds clean in the Hinode exampleSite; markdownlint passes.
Related
coverflagcoverargument description🤖 Generated with Claude Code