fix(local): tail events in run when a server already owns the port - #1342
Merged
MathurAditya724 merged 1 commit intoAug 3, 2026
Merged
Conversation
`local run` only printed events when it started the background server itself. When something else was already listening — most often the Spotlight desktop app's own sidecar — it injected SENTRY_SPOTLIGHT, spawned the child, and then stayed silent for the whole session: no logs, no traces, even though envelopes were flowing to that server. Attach as an SSE consumer in that case, which is what `local serve` already does, so the terminal tail works regardless of who owns the port. The subscription is torn down when the child exits. This became much more visible after #1341: now that the CLI server advertises itself as a Spotlight sidecar, the desktop app keeps its own sidecar on 8969 instead of losing the race, so `run` hits the attach path far more often. Co-authored-by: Aditya Mathur <MathurAditya724@users.noreply.github.com>
MathurAditya724
enabled auto-merge (squash)
August 3, 2026 06:22
Contributor
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
MathurAditya724
deleted the
cursor/fix-local-run-tail-existing-server-27d6
branch
August 3, 2026 06:31
MathurAditya724
added a commit
that referenced
this pull request
Aug 3, 2026
consumeSSE() gave up silently when the very first connection attempt failed. /health can answer 200 while /stream does not — an unrelated service squatting on the port, or the server going away between the two requests — and in that case nothing was ever printed again. That is worst in `local run`, which keeps the child process alive: the user saw 'Connected to existing server', then no events for the rest of the session with no explanation. Emit a warning before giving up, and log the 200-with-no-body case that was also returning silently. Addresses the review comment on #1342. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Aditya Mathur <MathurAditya724@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
local runonly printed events when it started the background server itself. When something else was already listening — most often the Spotlight desktop app's own sidecar — it injected SENTRY_SPOTLIGHT, spawned the child, and then stayed silent for the whole session: no logs, no traces, even though envelopes were flowing to that server.Attach as an SSE consumer in that case, which is what
local servealready does, so the terminal tail works regardless of who owns the port. The subscription is torn down when the child exits.This became much more visible after #1341: now that the CLI server advertises itself as a Spotlight sidecar, the desktop app keeps its own sidecar on 8969 instead of losing the race, so
runhits the attach path far more often.