fix(#298): add go install instructions to bundled notion-cli plugin - #368
Closed
javimosch wants to merge 1 commit into
Closed
fix(#298): add go install instructions to bundled notion-cli plugin#368javimosch wants to merge 1 commit into
javimosch wants to merge 1 commit into
Conversation
Add the primary `go install github.com/4ier/notion-cli@latest` method from the issue to plugin.json, install-guidance.json, and the quickstart skill. Homebrew and npm remain documented as alternatives. Fixes #298 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
📝 WalkthroughWalkthroughThe Notion CLI installation guidance now uses ChangesNotion CLI installation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/notion-cli/install-guidance.json`:
- Around line 6-7: Document and export the Go binary directory before verifying
the installed command: update plugins/notion-cli/install-guidance.json lines
6-7, plugins/notion-cli/plugin.json lines 14-15, 33, and 233, and
plugins/notion-cli/skills/quickstart/SKILL.md lines 61-63. Ensure each
installation surface adds the Go bin path to PATH before the notion --version or
which notion check, while preserving the existing fallback installation
guidance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 71600cb1-e64b-4fee-ae0d-e6cfb6ea21b9
📒 Files selected for processing (3)
plugins/notion-cli/install-guidance.jsonplugins/notion-cli/plugin.jsonplugins/notion-cli/skills/quickstart/SKILL.md
Comment on lines
+6
to
7
| "go install github.com/4ier/notion-cli@latest", | ||
| "Verify: notion --version", |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
command -v go >/dev/null
gobin="$(go env GOBIN)"
if [ -z "$gobin" ]; then
gobin="$(go env GOPATH)/bin"
fi
case ":${PATH}:" in
*":${gobin}:"*) ;;
*) printf 'Go binary directory is not on PATH: %s\n' "$gobin" >&2; exit 1 ;;
esacRepository: javimosch/supercli
Length of output: 214
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf 'GOMODCACHE: '
go env GOMODCACHE
printf 'GOBIN: %s\n' "$(go env GOBIN || true)"
printf 'GOPATH: %s\n' "$(go env GOPATH || true)"
printf 'PATH includes standard Go bin? '
gobin="$(go env GOBIN || true)"
if [ -z "$gobin" ]; then
gobin="$(go env GOPATH)/bin"
fi
case ":${PATH}:" in
*":${gobin}:"*) echo yes ;;
*) echo no; printf 'actual PATH contains: ' ; sed -n 's#:/##p' <<< "$PATH" | tr ':' '\n' | head -20 ;;
esac
printf '\nGo toolchain availability:\n'
command -v go || true
go version 2>/dev/null || true
printf '\nRelevant file excerpts:\n'
for f in plugins/notion-cli/install-guidance.json plugins/notion-cli/plugin.json plugins/notion-cli/skills/quickstart/SKILL.md; do
echo "--- $f"
sed -n '1,260p' "$f"
doneRepository: javimosch/supercli
Length of output: 12426
Document the go install binary directory in the installation guidance.
go install places binaries in $(go env GOBIN || $(go env GOPATH)/bin)/bin, and that directory is not documented on the installation surfaces. Since the installed binary must satisfy which notion, add the exported Go bin path as the install step before notion --version, or use an alternative install method, and include the same step in install-guidance.json, plugin.json fallback install, and skills/quickstart/SKILL.md.
📍 Affects 3 files
plugins/notion-cli/install-guidance.json#L6-L7(this comment)plugins/notion-cli/plugin.json#L14-L15plugins/notion-cli/plugin.json#L33-L33plugins/notion-cli/plugin.json#L233-L233plugins/notion-cli/skills/quickstart/SKILL.md#L61-L63
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@plugins/notion-cli/install-guidance.json` around lines 6 - 7, Document and
export the Go binary directory before verifying the installed command: update
plugins/notion-cli/install-guidance.json lines 6-7,
plugins/notion-cli/plugin.json lines 14-15, 33, and 233, and
plugins/notion-cli/skills/quickstart/SKILL.md lines 61-63. Ensure each
installation surface adds the Go bin path to PATH before the notion --version or
which notion check, while preserving the existing fallback installation
guidance.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated maintenance run by automaintainer.
Focus: == ASSIGNED OBJECTIVE ==
Fix GitHub issue #298 ONLY: Add 4ier/notion-cli as a bundled plugin in SuperCLI. PR title MUST reference #298.
OPEN PR AWARENESS (secondary — do not replace the ASSIGNED OBJECTIVE):
These open pull requests are already open and awaiting review. Do NOT start UNRELATED work on the files they touch. If your ASSIGNED OBJECTIVE requires editing one of those files, complete the objective anyway. Never abandon the objective to pick a different GitHub issue just to avoid overlap.
touches: plugins/notion-cli/install-guidance.json, plugins/notion-cli/plugin.json, plugins/notion-cli/skills/quickstart/SKILL.md
touches: plugins/notion-cli/install-guidance.json, plugins/notion-cli/plugin.json, plugins/notion-cli/skills/quickstart/SKILL.md
run <plugin> <resource> <action>one-shot command #365 (am/am-f17c27-dkdoeotqzvn8-3120cd1a): fix(feat:sc run <plugin> <action>— one-shot discover+install+execute #335): implementrun <plugin> <resource> <action>one-shot commandtouches: tests/run-command.test.js, cli/help-json.js, cli/help.js, cli/run.js, cli/supercli.js
touches: .github/workflows/sc-machin-release.yml, README.md, supercli-machin-cli/README.md, supercli-machin-cli/install.sh
Branch:
am/am-f17c27-dkfdt4lkqz9c-84d0eb58Diff:
Summary by CodeRabbit
go installas the primary method.