chore: replace broken-link-checker with linkinator#788
Open
mcdurdin wants to merge 1 commit into
Open
Conversation
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
force-pushed
the
chore/linkinator
branch
2 times, most recently
from
2a8334f to
b5f9cfc
Compare
mcdurdin
force-pushed
the
chore/use-common-function-for-http-requests
branch
from
0b9e537 to
ece6d4f
Compare
mcdurdin
force-pushed
the
chore/linkinator
branch
7 times, most recently
from
5dd53bf to
3317ea7
Compare
mcdurdin
added a commit
to keymanapp/help.keyman.com
that referenced
this pull request
Jun 15, 2026
This was referenced Jun 15, 2026
mcdurdin
force-pushed
the
chore/linkinator
branch
from
3317ea7 to
c207fdb
Compare
mcdurdin
added a commit
to keymanapp/shared-sites
that referenced
this pull request
Jun 15, 2026
Relates-to: keymanapp/keyman.com#788 Test-bot: skip
mcdurdin
added a commit
to keymanapp/help.keyman.com
that referenced
this pull request
Jun 15, 2026
mcdurdin
added a commit
to keymanapp/keymanweb.com
that referenced
this pull request
Jun 15, 2026
Based-on: keymanapp/keyman.com#788 Test-bot: skip
mcdurdin
force-pushed
the
chore/linkinator
branch
from
c207fdb to
a62ceda
Compare
mcdurdin
added a commit
to keymanapp/shared-sites
that referenced
this pull request
Jun 15, 2026
Relates-to: keymanapp/keyman.com#788 Test-bot: skip
Broken-link-checker (BLC) is basically dead -- no releases for 8 years, no updates to master for 5. The trigger for this change is, however, that BLC was not honoring exclusions on redirects, which cause sporadic errors (e.g. 429) because we hit external servers in our link test. Replace with linkinator, which is in maintenance and does the job pretty well. I have forked linkinator and added some patches specific to our environment which I may push upstream later when we are confident of the setup. Unify the ci.yml and build.sh test steps (this will need to be tested in CI once this merges to master). Test-bot: skip
mcdurdin
force-pushed
the
chore/linkinator
branch
from
a62ceda to
609464e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken-link-checker (BLC) is basically dead -- no releases for 8 years, no updates to master for 5. The trigger for this change is, however, that BLC was not honoring exclusions on redirects, which cause sporadic errors (e.g. 429) because we hit external servers in our link test.
Replace with linkinator, which is in maintenance and does the job pretty well.
I have forked linkinator and added some patches specific to our environment which I may push upstream later when we are confident of the setup:
Unify the ci.yml and build.sh test steps.
I have compared the crawl results and they appear to be essentially identical (differences in reporting on redirects means a 1:1 comparison is not possible).
Test-bot: skip