nightly: remove stale bf_tree feature from DISKANN_FEATURES#1112
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job clippy-features on macos
nightly: remove stale May 28, 2026
bf_tree feature from DISKANN_FEATURES
JordanMaples
approved these changes
May 28, 2026
arrayka
approved these changes
Jun 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the stale bf_tree entry from the DISKANN_FEATURES env var in the nightly GitHub Actions workflow so the nightly clippy-features (macos) job no longer references a non-existent workspace feature, aligning nightly.yml with the already-updated ci.yml.
Changes:
- Drop
bf_treefrom theDISKANN_FEATURESlist in.github/workflows/nightly.yml. - Keep the nightly feature matrix consistent with CI by only listing currently supported feature flags.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
=======================================
Coverage 89.46% 89.46%
=======================================
Files 482 482
Lines 91092 91092
=======================================
Hits 81497 81497
Misses 9595 9595
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
arkrishn94
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly
clippy-features (macos)job was failing becausenightly.ymlstill listedbf_treeinDISKANN_FEATURES, but no workspace package defines that feature. Thediskann-bftreecrate is a first-class workspace member and needs no feature gate;ci.ymlhad already droppedbf_treebutnightly.ymlwas never updated.Changes
.github/workflows/nightly.yml: removebf_tree,fromDISKANN_FEATURES, aligning it withci.yml.After the fix, it passes: https://github.com/microsoft/DiskANN/actions/runs/26866739218