Skip to content

nightly: remove stale bf_tree feature from DISKANN_FEATURES#1112

Merged
arrayka merged 2 commits into
mainfrom
copilot/fix-clippy-features-macos
Jun 3, 2026
Merged

nightly: remove stale bf_tree feature from DISKANN_FEATURES#1112
arrayka merged 2 commits into
mainfrom
copilot/fix-clippy-features-macos

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 28, 2026

The nightly clippy-features (macos) job was failing because nightly.yml still listed bf_tree in DISKANN_FEATURES, but no workspace package defines that feature. The diskann-bftree crate is a first-class workspace member and needs no feature gate; ci.yml had already dropped bf_tree but nightly.yml was never updated.

Changes

  • .github/workflows/nightly.yml: remove bf_tree, from DISKANN_FEATURES, aligning it with ci.yml.

After the fix, it passes: https://github.com/microsoft/DiskANN/actions/runs/26866739218

Copilot AI changed the title [WIP] Fix failing GitHub Actions job clippy-features on macos nightly: remove stale bf_tree feature from DISKANN_FEATURES May 28, 2026
Copilot AI requested a review from arrayka May 28, 2026 16:10
@arrayka arrayka marked this pull request as ready for review June 3, 2026 05:55
@arrayka arrayka requested review from a team and Copilot June 3, 2026 05:55
@arrayka arrayka enabled auto-merge (squash) June 3, 2026 05:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the stale bf_tree entry from the DISKANN_FEATURES env var in the nightly GitHub Actions workflow so the nightly clippy-features (macos) job no longer references a non-existent workspace feature, aligning nightly.yml with the already-updated ci.yml.

Changes:

  • Drop bf_tree from the DISKANN_FEATURES list in .github/workflows/nightly.yml.
  • Keep the nightly feature matrix consistent with CI by only listing currently supported feature flags.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.46%. Comparing base (f8bbf3e) to head (4790a6e).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1112   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         482      482           
  Lines       91092    91092           
=======================================
  Hits        81497    81497           
  Misses       9595     9595           
Flag Coverage Δ
miri 89.46% <ø> (ø)
unittests 89.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arrayka arrayka merged commit ff49769 into main Jun 3, 2026
28 checks passed
@arrayka arrayka deleted the copilot/fix-clippy-features-macos branch June 3, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants