Remove net6.0 target

.github/workflows/benchmark.yml

@@ -13,10 +13,10 @@ jobs:
     name: Run Benchmark.Net
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v7
       - uses: actions/setup-dotnet@v5
         with:
-          dotnet-version: 8.0.100
+          dotnet-version: 8.0.x
       - name: Run benchmark
         run: cd BenchmarkTests && dotnet run -c Release --framework net8.0 --exporters json --filter '*'
 

.github/workflows/ci-cd.yml

@@ -8,14 +8,14 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       # Tooling setup
 
       - name: Install .NET SDK
         uses: actions/setup-dotnet@v5
         with:
-          dotnet-version: 8.0.100
+          dotnet-version: 8.0.x
 
       # Build and test validation
 
@@ -38,7 +38,7 @@ jobs:
           --no-build
 
       - name: Upload test results as pipeline artifact
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: Test results
           path: 'Test results/'
@@ -65,7 +65,7 @@ jobs:
           }
 
       - name: Upload publish output as pipeline artifact
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: Publish outputs
           path: 'Publish outputs/'

.github/workflows/codeql-analysis.yml

@@ -18,10 +18,10 @@ jobs:
       - name: Setup .NET SDK
         uses: actions/setup-dotnet@v5
         with:
-          dotnet-version: 8.0.100
+          dotnet-version: 8.0.x
 
       - name: Checkout repository
-        uses: actions/checkout@v6
+        uses: actions/checkout@v7
 
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v4

CHANGES.md

@@ -1,3 +1,12 @@
+# Version 4.0.0
+
+**Breaking Changes**
+* Dropping net6.0 will more easily support trimming [PR #409](https://github.com/microsoft/Microsoft.IO.RecyclableMemoryStream/pull/409)
+* Switch `MemoryStreamDoubleDispose` event level from Critical to Verbose [PR #406](https://github.com/microsoft/Microsoft.IO.RecyclableMemoryStream/pull/406)
+
+**Other Changes**
+* Readme: Add clarity for the large pool of buffers and the GetBuffer method pertaining to the .NET max array length [PR #370](https://github.com/microsoft/Microsoft.IO.RecyclableMemoryStream/pull/370)
+
 # Version 3.0.1
 
 **Bug Fix**

README.md

@@ -211,7 +211,7 @@ You can optionally configure the `RecyclableStreamManager.ThrowExceptionOnToArra
 | -----|-------|-------------|
 | MemoryStreamCreated | Verbose | Logged every time a stream object is allocated. Fields: `guid`, `tag`, `requestedSize`, `actualSize`. |
 | MemoryStreamDisposed | Verbose | Logged every time a stream object is disposed. Fields: `guid`, `tag`, `allocationStack`, `disposeStack`. |
-| MemoryStreamDoubleDispose | Critical | Logged if a stream is disposed more than once. This indicates a logic error by the user of the stream. Dispose should happen exactly once per stream to avoid resource usage bugs. Fields: `guid`, `tag`, `allocationStack`, `disposeStack1`, `disposeStack2`. |
+| MemoryStreamDoubleDispose | Verbose | Logged if a stream is disposed more than once. This indicates a logic error by the user of the stream. Dispose should happen exactly once per stream to avoid resource usage bugs. Fields: `guid`, `tag`, `allocationStack`, `disposeStack1`, `disposeStack2`. |
 | MemoryStreamFinalized | Error | Logged if a stream has gone out of scope without being disposed. This indicates a resource leak. Fields: `guid`, `tag`, `allocationStack`.|
 | MemoryStreamToArray | Verbose | Logged whenever `ToArray` is called. This indicates a potential problem, as calling `ToArray` goes against the concepts of good memory practice which `RecyclableMemoryStream` is trying to solve. Fields: `guid`, `tag`, `stack`, `size`.|
 | MemoryStreamManagerInitialized| Informational | Logged when the `RecyclableMemoryStreamManager` is initialized. Fields: `blockSize`, `largeBufferMultiple`, `maximumBufferSize`.|

UnitTests/Tests.cs

@@ -4057,9 +4057,8 @@ protected override void TestDroppingLargeBuffer(long maxFreeLargeBufferSize)
                 }
             }
         }
-#pragma warning disable 618 // Timeout is obsolete because it kills the thread, which isn't allowed, but it's still handy
-                            // for tests that are expected to run indefinitely in the failure case.
-        [Test, Timeout(10000)]
+
+        [Test, MaxTime(10000)]
         public void TryGetBuffer_InfiniteLoop_Issue344()
         {
             // see https://github.com/microsoft/Microsoft.IO.RecyclableMemoryStream/issues/344

UnitTests/UnitTests.csproj

@@ -9,10 +9,10 @@
     <NoWarn>NUnit2045</NoWarn>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="nunit" Version="4.4.0" />
-    <PackageReference Include="NUnit3TestAdapter" Version="6.0.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
-    <PackageReference Include="NUnit.Analyzers" Version="4.11.2" PrivateAssets="All" />      
+    <PackageReference Include="nunit" Version="4.5.1" />
+    <PackageReference Include="NUnit3TestAdapter" Version="6.2.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.6.0" />
+    <PackageReference Include="NUnit.Analyzers" Version="4.14.0" PrivateAssets="All" />      
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\src\Microsoft.IO.RecyclableMemoryStream.csproj" />

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "8.0.416",
+    "version": "8.0.422",
     "rollForward": "latestMinor"
   }
 }

src/Events.cs

@@ -110,7 +110,7 @@ public void MemoryStreamDisposed(Guid guid, string? tag, long lifetimeMs, string
             /// <param name="disposeStack1">Call stack of the first dispose.</param>
             /// <param name="disposeStack2">Call stack of the second dispose.</param>
             /// <remarks>Note: Stacks will only be populated if RecyclableMemoryStreamManager.GenerateCallStacks is true.</remarks>
-            [Event(3, Level = EventLevel.Critical)]
+            [Event(3, Level = EventLevel.Verbose)]
             public void MemoryStreamDoubleDispose(Guid guid, string? tag, string? allocationStack, string? disposeStack1,
                                                   string? disposeStack2)
             {

src/Microsoft.IO.RecyclableMemoryStream.csproj

@@ -1,13 +1,13 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.0;netstandard2.1;net6.0</TargetFrameworks>
+    <TargetFrameworks>netstandard2.0;netstandard2.1;net8.0</TargetFrameworks>
     <CheckEolTargetFramework>false</CheckEolTargetFramework>
     <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
     <RootNamespace>Microsoft.IO</RootNamespace>
     <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\Microsoft.IO.RecyclableMemoryStream.xml</DocumentationFile>
     <!-- NuGet properties -->
     <PackageId>Microsoft.IO.RecyclableMemoryStream</PackageId>
-    <PackageVersion>3.0.1</PackageVersion>
+    <PackageVersion>4.0.0-alpha</PackageVersion>
     <Title>Microsoft.IO.RecyclableMemoryStream</Title>
     <Authors>Microsoft</Authors>
     <Description>A pooled MemoryStream allocator to decrease GC load and improve performance on highly scalable systems.</Description>
@@ -43,7 +43,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.300" PrivateAssets="All" />
     <PackageReference Include="System.Memory" Version="4.6.3" Condition="'$(TargetFramework)' == 'netstandard2.0'" />
   </ItemGroup>
 

src/Properties/AssemblyInfo.cs

@@ -33,8 +33,8 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("3.0.1.0")]
-[assembly: AssemblyFileVersion("3.0.1.0")]
+[assembly: AssemblyVersion("4.0.0.0")]
+[assembly: AssemblyFileVersion("4.0.0.0")]
 
 [assembly: CLSCompliant(true)]
 

src/RecyclableMemoryStream.cs

@@ -280,7 +280,7 @@ protected override void Dispose(bool disposing)
             if (this.disposed)
             {
                 string? doubleDisposeStack = null;
-                if (this.memoryManager.options.GenerateCallStacks)
+                if (this.memoryManager.GenerateDoubleDisposedStackTrace)
                 {
                     doubleDisposeStack = Environment.StackTrace;
                 }

src/RecyclableMemoryStreamManager.cs

@@ -25,6 +25,7 @@ namespace Microsoft.IO
     using System;
     using System.Collections.Concurrent;
     using System.Collections.Generic;
+    using System.Diagnostics.Tracing;
     using System.Runtime.CompilerServices;
     using System.Threading;
 
@@ -82,6 +83,13 @@ public partial class RecyclableMemoryStreamManager
 
         internal readonly Options options;
 
+        internal bool GenerateDoubleDisposedStackTrace =>
+            this.options.GenerateCallStacks &&
+            (
+                this.StreamDoubleDisposed != null ||
+                Events.Writer.IsEnabled(EventLevel.Verbose, EventKeywords.None)
+            );
+
         /// <summary>
         /// Settings for controlling the behavior of RecyclableMemoryStream
         /// </summary>