Skip to content

[CMAKE] Remove environment variable support from the add external components script#4211

Open
dbarker wants to merge 2 commits into
open-telemetry:mainfrom
dbarker:cmake_remove_external_components_from_env_feature
Open

[CMAKE] Remove environment variable support from the add external components script#4211
dbarker wants to merge 2 commits into
open-telemetry:mainfrom
dbarker:cmake_remove_external_components_from_env_feature

Conversation

@dbarker

@dbarker dbarker commented Jul 3, 2026

Copy link
Copy Markdown
Member

Fixes #3409

Changes

  • Removes OPENTELEMETRY_EXTERNAL_COMPONENT_PATH and OPENTELEMETRY_EXTERNAL_COMPONENT_URL environment variable support from the cmake/opentelemetry-build-external-component.cmake script

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

…ake build using environment variables in favor or users building external components with opentelemetry-cpp as a dependency imported through find_package or FetchContent
@dbarker dbarker marked this pull request as ready for review July 3, 2026 14:26
@dbarker dbarker requested a review from a team as a code owner July 3, 2026 14:26
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.84%. Comparing base (1accbc0) to head (fc024e8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4211   +/-   ##
=======================================
  Coverage   82.84%   82.84%           
=======================================
  Files         415      415           
  Lines       17423    17423           
=======================================
  Hits        14433    14433           
  Misses       2990     2990           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harden the build external components feature

2 participants