Skip to content

[CMAKE] Remove environment variable support from the add external components script #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dbarker wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −25
Open

[CMAKE] Remove environment variable support from the add external components script #4211

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
454e63b
remove feature to add external components to the opentelemetry-cpp CM…
dbarker Jul 3, 2026
fc024e8
Adds a message if the external component is added. Clean up comments …
dbarker Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 4 additions & 25 deletions cmake/opentelemetry-build-external-component.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,37 +13,16 @@ endfunction()
# Enable building external components through otel-cpp build
# The config options are
# - OPENTELEMETRY_EXTERNAL_COMPONENT_PATH - Setting local paths of the external
# component as env variable. Multiple paths can be set by separating them with.
# - OPENTELEMETRY_EXTERNAL_COMPONENT_URL Setting github-repo of external component
# as env variable
# component. Multiple paths can be set by separating them with.

# Add custom vendor component from local path, or GitHub repo
# Prefer CMake option, then env variable, then URL.
# Add custom vendor component from local path
# CMake option.
if(OPENTELEMETRY_EXTERNAL_COMPONENT_PATH)
message(STATUS "Building external components from local path(s): ${OPENTELEMETRY_EXTERNAL_COMPONENT_PATH}")
# Add custom component path to build tree and consolidate binary artifacts in
# current project binary output directory.
foreach(DIR IN LISTS OPENTELEMETRY_EXTERNAL_COMPONENT_PATH)
get_directory_name_in_path(${DIR} EXTERNAL_EXPORTER_DIR_NAME)
add_subdirectory(${DIR} ${PROJECT_BINARY_DIR}/external/${EXTERNAL_EXPORTER_DIR_NAME})
endforeach()
elseif(DEFINED ENV{OPENTELEMETRY_EXTERNAL_COMPONENT_PATH})
# Add custom component path to build tree and consolidate binary artifacts in
# current project binary output directory.
set(OPENTELEMETRY_EXTERNAL_COMPONENT_PATH_VAR $ENV{OPENTELEMETRY_EXTERNAL_COMPONENT_PATH})
foreach(DIR IN LISTS OPENTELEMETRY_EXTERNAL_COMPONENT_PATH_VAR)
get_directory_name_in_path(${DIR} EXTERNAL_EXPORTER_DIR_NAME)
add_subdirectory(${DIR} ${PROJECT_BINARY_DIR}/external/${EXTERNAL_EXPORTER_DIR_NAME})
endforeach()
elseif(DEFINED $ENV{OPENTELEMETRY_EXTERNAL_COMPONENT_URL})
# This option requires CMake 3.11+: add standard remote repo to build tree.
include(FetchContent)
FetchContent_Declare(
external
GIT_REPOSITORY $ENV{OPENTELEMETRY_EXTERNAL_COMPONENT_URL}
GIT_TAG "main")
FetchContent_GetProperties(external)
if(NOT external_POPULATED)
FetchContent_Populate(external)
add_subdirectory(${external_SOURCE_DIR})
endif()
endif()
Loading