Skip to content

SRVOCF-999: Install Helm in CI for plugin deployment - #35

Open
Cragsmann wants to merge 2 commits into
openshift:masterfrom
Cragsmann:SRVOCF-999-helm-removal
Open

SRVOCF-999: Install Helm in CI for plugin deployment#35
Cragsmann wants to merge 2 commits into
openshift:masterfrom
Cragsmann:SRVOCF-999-helm-removal

Conversation

@Cragsmann

@Cragsmann Cragsmann commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

  • Install Helm at runtime in the CI script using the official get-helm-3 v3.21.3 installer, since the CI image does not include it
  • Removed unused install-helm.sh

Fixes SRVOCF-999

Checklist

  • Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture) — N/A, CI script only

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 29, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@Cragsmann: This pull request references SRVOCF-999 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Replace helm install with inline oc apply -f - manifests (Service, Deployment, ConsolePlugin CR) since the CI image lacks Helm and has no internet access
  • Pass --external-api-server-url to the backend, resolved from the Infrastructure CR, to prevent CrashLoopBackOff
  • Remove the ConsolePlugin wait loop since oc apply creates all resources synchronously

Fixes SRVOCF-999

Checklist

  • Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture) — N/A, CI script only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from pmeida and twoGiants July 29, 2026 16:06
@openshift-ci

openshift-ci Bot commented Jul 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cragsmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2026
@Cragsmann
Cragsmann force-pushed the SRVOCF-999-helm-removal branch from 66eed50 to ed69741 Compare July 30, 2026 09:51
@Cragsmann Cragsmann changed the title SRVOCF-999: Replace Helm with inline oc apply in CI deploy script SRVOCF-999: Install Helm in CI for plugin deployment Jul 30, 2026
@Cragsmann @claude
ci: install Helm in CI for plugin deployment
3b84ebc 
The CI image lacks Helm, which is needed to deploy the plugin
via the existing Helm chart. Install it at runtime using the
official get-helm-3 script.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Cragsmann
Cragsmann force-pushed the SRVOCF-999-helm-removal branch from ed69741 to 3b84ebc Compare July 30, 2026 09:55
@pmeida

pmeida commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Can u reuse the install_helm.sh or delete it?

@Cragsmann @claude
chore: remove unused install_helm.sh
325d069 
Helm installation is now handled inline in
test-prow-e2e.sh (3b84ebc). This standalone script
has no remaining callers.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Cragsmann

Cragsmann commented Jul 30, 2026

Copy link
Copy Markdown
Author

Can u reuse the install_helm.sh or delete it?

I removed it since it was not used anywhere else

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown

@Cragsmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dsimansk
dsimansk reviewed Jul 30, 2026
View reviewed changes
Comment thread test-prow-e2e.sh
Comment on lines +36 to +39
# --- Install Helm ---
echo "Installing Helm..."
curl -fsSL https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | DESIRED_VERSION=v3.21.3 bash

@dsimansk dsimansk Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep non-sudo config options? I'd say it's not gonna be executed under root by default.

USE_SUDO="false"
HELM_INSTALL_DIR="/tmp"

@dsimansk dsimansk Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wrap it in if not found helm at least?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsimansk dsimansk dsimansk left review comments
@pmeida pmeida Awaiting requested review from pmeida
@twoGiants twoGiants Awaiting requested review from twoGiants

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cragsmann @openshift-ci-robot @pmeida @dsimansk