Skip to content

SRVOCF-999: Install Helm in CI for plugin deployment #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Jul 31, 2026
+4 −10
Merged

SRVOCF-999: Install Helm in CI for plugin deployment #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b84ebc
ci: install Helm in CI for plugin deployment
Cragsmann Jul 30, 2026
325d069
chore: remove unused install_helm.sh
Cragsmann Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions install_helm.sh
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions test-prow-e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ if [[ -z "${PLUGIN_PULL_SPEC:-}" ]]; then
exit 1
fi

# --- Install Helm ---
echo "Installing Helm..."
curl -fsSL https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | DESIRED_VERSION=v3.21.3 bash

Comment on lines +36 to +39

@dsimansk dsimansk Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep non-sudo config options? I'd say it's not gonna be executed under root by default.

USE_SUDO="false"
HELM_INSTALL_DIR="/tmp"

@dsimansk dsimansk Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wrap it in if not found helm at least?

@dsimansk dsimansk Jul 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. running locally, I'd skip the install because I have /opt/homebrew/bin/helm and don't want to override.

➜  ~ curl -fsSL https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | DESIRED_VERSION=v3.21.3 bash
Downloading https://get.helm.sh/helm-v3.21.3-darwin-arm64.tar.gz
Verifying checksum... Done.
Preparing to install helm into /usr/local/bin
Password:

@pmeida pmeida Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note
test-prow-e2e.sh is not meant to run locally, we have yarn test:e2e for that purpose

@dsimansk dsimansk Jul 31, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then it's fine, we can disregard my comments

# --- Deploy plugin ---
oc new-project "${PLUGIN_NAMESPACE}" || oc project "${PLUGIN_NAMESPACE}"

Expand Down