openshift/installer: enroll in pipeline controller LGTM mode#81544
Merged
Conversation
openshift-ci
Bot
added
the
approved
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (31)
📒 Files selected for processing (40)
🚧 Files skipped from review as they are similar to previous changes (36)
WalkthroughCI operator configs update many installer and priv-installer jobs to use ChangesCI trigger migration
Estimated code review effort: 4 (Complex) | ~60 minutes Suggested labels: Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
|
Contributor
|
/lgtm but needs a rebase |
openshift-ci
Bot
added
the
needs-rebase
Contributor
|
/lgtm |
jmguzik
force-pushed
the
convert-5
branch
2 times, most recently
from
d05238d to
deae2d3
Compare
openshift-ci
Bot
removed
lgtm
Contributor
Author
|
/pj-rehearse ack |
Contributor
|
@jmguzik: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
rehearsals-ack
Convert all e2e tests across branches 4.15-5.1 to use the pipeline controller second-stage model: - run_if_changed → pipeline_run_if_changed (697 instances) - skip_if_only_changed → pipeline_skip_if_only_changed (12 instances) - Set always_run: false on required e2e tests (143 instances) Non-e2e first-stage tests (unit, lint, vet) are left unchanged as pipeline gates. Add openshift/installer to the LGTM config so second-stage tests trigger on /lgtm label. Made with Cursor Signed-off-by: Jakub Guzik <jguzik@redhat.com>
Contributor
|
[REHEARSALNOTIFIER]
A total of 830 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
Author
|
/pj-rehearse ack |
Member
|
/lgtm |
deepsm007
approved these changes
Jul 8, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, jmguzik, patrickdillon, Prucek, sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, jmguzik, patrickdillon, Prucek, sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
@jmguzik: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Contributor
|
@jmguzik: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
SachinNinganure
pushed a commit
to SachinNinganure/release
that referenced
this pull request
Jul 9, 2026
…ft#81544) Convert all e2e tests across branches 4.15-5.1 to use the pipeline controller second-stage model: - run_if_changed → pipeline_run_if_changed (697 instances) - skip_if_only_changed → pipeline_skip_if_only_changed (12 instances) - Set always_run: false on required e2e tests (143 instances) Non-e2e first-stage tests (unit, lint, vet) are left unchanged as pipeline gates. Add openshift/installer to the LGTM config so second-stage tests trigger on /lgtm label. Made with Cursor Signed-off-by: Jakub Guzik <jguzik@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert all e2e tests across branches 4.15-5.1 to use the pipeline controller second-stage model:
Non-e2e first-stage tests (unit, lint, vet) are left unchanged as pipeline gates. Add openshift/installer to the LGTM config so second-stage tests trigger on /lgtm label.
Made with Cursor
Summary by CodeRabbit
Updated OpenShift installer CI/e2e configuration on release branches 4.15–5.1 to use the pipeline controller second-stage (“LGTM”) gating model. Across the installer e2e job definitions (including both
openshift/installerandopenshift-priv/installerconfigs), this changes change-detection keys fromrun_if_changed→pipeline_run_if_changed(697 instances) andskip_if_only_changed→pipeline_skip_if_only_changed(12 instances), and standardizes required e2e runs withalways_run: false(143 tests) so they only execute when relevant paths change.Non-e2e first-stage gates (unit/lint/vet) were left as-is. Finally, added
openshift/installerto the pipeline-controller LGTM config so these second-stage installer e2e jobs can be triggered via the/lgtmlabel.