[3/n] [sync-switch] move bfd and address lot reads back to bg task, make the builder pure#10644
Merged
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
This was referenced Jun 20, 2026
Created using spr 1.3.6-beta.1 [skip ci]
This was referenced Jun 20, 2026
[9/n] [sync-switch] bail on an incomplete bootstore config instead of silently dropping items
#10650
Open
sunshowers
changed the base branch from
sunshowers/spr/main.3n-sync-switch-move-bfd-and-address-lot-reads-back-to-bg-task-make-the-builder-pure
to
main
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/3n-sync-switch-move-bfd-and-address-lot-reads-back-to-bg-task-make-the-builder-pure
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the infra address-lot and BFD reads back into the caller, passing their results in via a new
RackNetworkConfigInputstruct. With those gone, the builder performs no database access at all, so it becomes a synchronous, pure function.The nexus-switch-config crate still has dependencies on nexus-db-model and nexus-db-queries, but those are only for types. Later commits in the series will introduce domain types and get rid of this dependency.
This commit reorders some reads slightly, but otherwise is meant to be pure refactoring with no functional changes.
Depends on: