streams: refactor _php_stream_opendir()#22836
Open
Girgias wants to merge 2 commits into
Open
Conversation
Girgias
force-pushed
the
2026-07-stream_dir_opener-refactor
branch
from
July 21, 2026 00:11
723a653 to
44ec5a6
Compare
Girgias
force-pushed
the
2026-07-stream_dir_opener-refactor
branch
from
July 21, 2026 11:40
44ec5a6 to
721eaf4
Compare
Girgias
marked this pull request as ready for review
July 21, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation is make the code more legible, use the newer stream error APIs, and let the wrapper hook handle the
REPORT_ERRORoption in a way it decides in the future. As currently if the wrapper emits errors and returns a stream, those errors are suppressed.