Fix: prevent IDOR in store invoice endpoint#17
Open
FuturMix wants to merge 1 commit into
Open
Conversation
The invoice GET endpoint queries by ID without filtering by user_id, then checks ownership after retrieval. This leaks invoice existence (404 vs 403 status codes) and relies on application-level checks instead of query-level filtering. Move the user_id filter into the query itself, and replace the raw error.message with a generic error to prevent information disclosure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16
The invoice endpoint queries by ID without user_id filtering, leaking invoice existence via different status codes.
Changes
apps/web/src/app/api/store/invoices/[id]/route.ts:.eq('user_id', auth.userId)to queryerror.messagewith generic errorTest plan
🤖 Generated with Claude Code