Skip to content

Fix: prevent IDOR in store invoice endpoint #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FuturMix wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

Fix: prevent IDOR in store invoice endpoint #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions apps/web/src/app/api/store/invoices/[id]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ export async function GET(req: NextRequest, ctx: { params: Promise<{ id: string
from: (t: string) => {
select: (s: string) => {
eq: (col: string, val: string) => {
eq: (col: string, val: string) => {
maybeSingle: () => Promise<{ data: InvoiceRow | null; error: { message: string } | null }>;
};
maybeSingle: () => Promise<{ data: InvoiceRow | null; error: { message: string } | null }>;
};
};
Expand All @@ -46,10 +49,10 @@ export async function GET(req: NextRequest, ctx: { params: Promise<{ id: string
const { data, error } = await c.from('plugin_invoices')
.select('id, user_id, plugin_id, coinpay_payment_id, amount_usd, blockchain, payment_address, crypto_amount, qr_code, status, expires_at, paid_at, forwarded_at, created_at, updated_at')
.eq('id', id)
.eq('user_id', auth.userId)
.maybeSingle();
if (error) return Response.json({ error: error.message }, { status: 500 });
if (error) return Response.json({ error: 'Failed to fetch invoice' }, { status: 500 });
if (!data) return Response.json({ error: 'invoice not found' }, { status: 404 });
if (data.user_id !== auth.userId) return Response.json({ error: 'unauthorized' }, { status: 403 });

// Optionally refresh status from Coinpay so the UI shows fast progress
// without waiting for the webhook to land.
Expand Down
Loading