P3 service chaining#3591
Draft
lann wants to merge 2 commits into
Draft
Conversation
lann
commented
Jun 25, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
itowlson
approved these changes
Jun 25, 2026
itowlson
left a comment
itowlson
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! It would be great to add a test - Rajat had one in his branch I think, or based on the existing service chaining tests. (But we can retrofit that if you need to get back to other priorities.)
lann
force-pushed
the
p3-service-chaining
branch
from
bd0c76b to
1ed6d2f
Compare
lann
commented
Jun 25, 2026
Comment on lines
-691
to
-700
| /// An HTTP executor. | ||
| pub(crate) trait HttpExecutor { | ||
| fn execute<F: RuntimeFactors>( | ||
| &self, | ||
| instance_builder: TriggerInstanceBuilder<F>, | ||
| route_match: &RouteMatch<'_, '_>, | ||
| req: Request<Body>, | ||
| client_addr: SocketAddr, | ||
| ) -> impl Future<Output = anyhow::Result<Response<Body>>>; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Drive-by refactor removing this useless trait but it was difficult to extract from the rest of the work.
Collaborator
Author
|
This one is still a draft because I haven't tested it at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3586