fix(api): validate preview CORS origins by hostname - #812
Open
doresa0 wants to merge 1 commit into
Open
Conversation
Faucet and Index Supply CORS used origin.includes('vercel.app'), which
can reflect attacker-controlled hosts that merely contain that substring.
Match feedback.ts: parse the Origin URL and allow only https hosts that
are tempo.xyz, *.tempo.xyz, or *.vercel.app.
Closes tempoxyz#681
|
@doresa0 is attempting to deploy a commit to the Tempo Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faucet and Index Supply CORS used
origin.includes('vercel.app'), which can reflect attacker-controlled hosts that merely contain that substring. Align withfeedback.ts: parse the Origin URL and allow onlyhttpshosts that aretempo.xyz,*.tempo.xyz, or*.vercel.app.Testing
faucet.ts/index-supply.tsCORS helpersvercel.appsubstring are no longer reflected*.vercel.app/*.tempo.xyzorigins still allowedCloses #681