Skip to content

fix(api): validate preview CORS origins by hostname #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doresa0 wants to merge 1 commit into
base: main
Choose a base branch
from
+47 −12
Open

fix(api): validate preview CORS origins by hostname #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions src/pages/_api/api/faucet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,18 +53,36 @@ async function fund(address: `0x${string}`, headers: Record<string, string>): Pr
}
}

function cors(origin: string | null): Record<string, string> {
const allowedOrigins = ['https://tempo.xyz', 'https://docs.tempo.xyz']

if (origin?.includes('vercel.app')) allowedOrigins.push(origin)
if (process.env.NODE_ENV === 'development') allowedOrigins.push('http://localhost:5173')
function isAllowedPreviewOrigin(origin: string): boolean {
try {
const { hostname, protocol } = new URL(origin)
if (protocol !== 'https:') return false
// Hostname suffix — not substring — so attacker.example containing
// "vercel.app" in the path/host cannot spoof preview CORS.
return (
hostname === 'tempo.xyz' ||
hostname.endsWith('.tempo.xyz') ||
hostname.endsWith('.vercel.app')
)
} catch {
return false
}
}

function cors(origin: string | null): Record<string, string> {
const headers: Record<string, string> = {
'Access-Control-Allow-Methods': 'POST, OPTIONS',
'Access-Control-Allow-Headers': 'Content-Type, x-api-token',
}

if (origin && allowedOrigins.includes(origin)) headers['Access-Control-Allow-Origin'] = origin
if (process.env.NODE_ENV === 'development' && origin === 'http://localhost:5173') {
headers['Access-Control-Allow-Origin'] = origin
return headers
}

if (origin && isAllowedPreviewOrigin(origin)) {
headers['Access-Control-Allow-Origin'] = origin
}

return headers
}
29 changes: 23 additions & 6 deletions src/pages/_api/api/index-supply.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,19 +119,36 @@ export async function OPTIONS(request: Request): Promise<Response> {
return new Response(null, { status: 200, headers: cors(origin) })
}

function cors(origin: string | null): Record<string, string> {
const allowedOrigins = ['https://tempo.xyz', 'https://mainnet.docs.tempo.xyz']

if (origin?.includes('vercel.app')) allowedOrigins.push(origin)
if (process.env.NODE_ENV === 'development') allowedOrigins.push('http://localhost:5173')
function isAllowedPreviewOrigin(origin: string): boolean {
try {
const { hostname, protocol } = new URL(origin)
if (protocol !== 'https:') return false
// Hostname suffix — not substring — so attacker.example containing
// "vercel.app" in the path/host cannot spoof preview CORS.
return (
hostname === 'tempo.xyz' ||
hostname.endsWith('.tempo.xyz') ||
hostname.endsWith('.vercel.app')
)
} catch {
return false
}
}

function cors(origin: string | null): Record<string, string> {
const headers: Record<string, string> = {
'Access-Control-Allow-Methods': 'POST, OPTIONS',
'Access-Control-Allow-Headers': 'Content-Type, x-api-token',
}

if (origin && allowedOrigins.some((allowed) => origin.startsWith(allowed)))
if (process.env.NODE_ENV === 'development' && origin === 'http://localhost:5173') {
headers['Access-Control-Allow-Origin'] = origin
return headers
}

if (origin && isAllowedPreviewOrigin(origin)) {
headers['Access-Control-Allow-Origin'] = origin
}

return headers
}