Use one VMEC loss surface - #52
Draft
rogeriojorge wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
|
eduardolneto
approved these changes
Aug 12, 2026
eduardolneto
left a comment
eduardolneto
left a comment
Contributor
There was a problem hiding this comment.
This adds the changes mentioned in PR #51 README changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
boundary_thresholdtoTracing, with a default of1.0. The same value now controls the VMEC boundary event and the loss-fraction calculation.This removes the previous mismatch between termination at
s=1and loss detection ats=0.99. No test files changed.