[APP-16972] Add fields for registry item billing#868
Merged
Conversation
Field tag 17 collided with deprecated_status; move billing to tag 19. Regenerate Go and JS stubs for the registry item billing messages. Co-authored-by: Cursor <cursoragent@cursor.com>
Michael Lee (michaellee1019)
changed the title
Michael Lee (michaellee1019)
added
the
ready-for-protos
Michael Lee (michaellee1019)
requested review from
Evgeni Dobranov (edobranov),
Grant Mulitz (gmulz) and
Sagie Maoz (n0nick)
Sagie Maoz (n0nick)
approved these changes
Jun 18, 2026
|
Hey Michael Lee (@michaellee1019) — this PR has been approved and CI has been green for 3+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
Evgeni Dobranov (edobranov)
approved these changes
Jun 24, 2026
Evgeni Dobranov (edobranov)
left a comment
Evgeni Dobranov (edobranov)
left a comment
Member
There was a problem hiding this comment.
LGTM % one q
|
|
||
| // Usage cost information used by billing jobs to bill for monthly usage of the item. | ||
| // This is unset when no cost has been configured for the item. | ||
| RegistryItemBilling billing = 19; |
There was a problem hiding this comment.
Should this be optional too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds billing field to registry Get/List/Update APIs and a new type for paid modules. I made the structure based on fragment billing, and figured structuring it this way can help us keep parity with per-machine cost features. If you think its more complicated than necessary I can flatten it to a single field for now.
Also adds a billing cost type.