Get/Set Allowed Login Method for Orgs#871
Merged
Merged
Conversation
Michael Lee (michaellee1019)
added
the
ready-for-protos
Michael Lee (michaellee1019)
changed the title
Michael Lee (michaellee1019)
added
ready-for-protos
Michael Lee (michaellee1019)
requested review from
Evgeni Dobranov (edobranov),
Grant Mulitz (gmulz) and
Sagie Maoz (n0nick)
Evgeni Dobranov (edobranov)
approved these changes
Jun 29, 2026
Evgeni Dobranov (edobranov)
left a comment
Evgeni Dobranov (edobranov)
left a comment
Member
There was a problem hiding this comment.
LGTM % a code comment nit
|
|
||
| message ListOrganizationsRequest {} | ||
|
|
||
| // LoginMethod is an interactive login mechanism an organization may allow. |
There was a problem hiding this comment.
Suggested change
| // LoginMethod is an interactive login mechanism an organization may allow. | |
| // LoginMethod is an interactive login mechanism an organization may allow. | |
| // The options are kept in sync with our list of configured identity providers: | |
| // https://viam-prod.fusionauth.io/admin/identity-provider/ |
For posterity since there's a possibility we add more in the future (xbox lol):
| LOGIN_METHOD_APPLE = 4; | ||
| } | ||
|
|
||
| message AllowedLoginMethods { |
There was a problem hiding this comment.
Oh and could we add a code comment that [] means that all login methods are allowed? To reflect the implementation in https://github.com/viamrobotics/app/pull/12543 and whichever other PRs
|
Hey Michael Lee (@michaellee1019) — this PR has been approved and CI has been green for 5+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.