openshift/console: enroll in pipeline controller LGTM mode#81556
Conversation
Convert e2e tests across branches 4.15-5.1 to use the pipeline controller second-stage model: - skip_if_only_changed → pipeline_skip_if_only_changed (13 instances) - Set always_run: false on required e2e tests (12 instances) Add openshift/console to the LGTM config. Signed-off-by: Jakub Guzik <jguzik@redhat.com>
WalkthroughThis PR updates Prow CI configurations for openshift/console across multiple release branches (main, 4.15–4.23, 5.0, 5.1), adding ChangesCI pipeline config updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5 | ❌ 10❌ Failed checks (10 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/console/openshift-console-release-4.18.yaml`:
- Around line 81-83: The new pipeline_skip_if_only_changed field was added to
the e2e-gcp-console job config, but the generated ci-operator/jobs output has
not been refreshed. Run make update so prowgen regenerates the job definitions,
then commit the updated generated files along with the change to
openshift-console-release-4.18.yaml.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: dab016d9-aecc-4479-936a-52021fb91f75
⛔ Files ignored due to path filters (12)
ci-operator/jobs/openshift/console/openshift-console-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/console/openshift-console-release-4.15-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/console/openshift-console-release-4.16-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/console/openshift-console-release-4.17-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/console/openshift-console-release-4.18-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/console/openshift-console-release-4.19-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/console/openshift-console-release-4.20-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/console/openshift-console-release-4.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/console/openshift-console-release-4.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/console/openshift-console-release-4.23-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/console/openshift-console-release-5.0-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/console/openshift-console-release-5.1-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (13)
ci-operator/config/openshift/console/openshift-console-main.yamlci-operator/config/openshift/console/openshift-console-release-4.15.yamlci-operator/config/openshift/console/openshift-console-release-4.16.yamlci-operator/config/openshift/console/openshift-console-release-4.17.yamlci-operator/config/openshift/console/openshift-console-release-4.18.yamlci-operator/config/openshift/console/openshift-console-release-4.19.yamlci-operator/config/openshift/console/openshift-console-release-4.20.yamlci-operator/config/openshift/console/openshift-console-release-4.21.yamlci-operator/config/openshift/console/openshift-console-release-4.22.yamlci-operator/config/openshift/console/openshift-console-release-4.23.yamlci-operator/config/openshift/console/openshift-console-release-5.0.yamlci-operator/config/openshift/console/openshift-console-release-5.1.yamlcore-services/pipeline-controller/lgtm-config.yaml
|
@jhadvig @rhamilto @spadgett @TheRealJon FYI. This is followup of communication of CI changes made via email on 23.06 |
|
/pj-rehearse ack |
|
@jmguzik: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deepsm007, jmguzik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jmguzik: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Convert e2e tests across branches 4.15-5.1 to use the pipeline controller second-stage model:
Add openshift/console to the LGTM config.
Summary by CodeRabbit
Updates
openshift/consoleCI configuration to use the pipeline controller second-stage model for e2e jobs across supported release branches, which changes how these jobs are skipped and ensures required e2e tests are treated as non-always-run. Also addsopenshift/consoleto the LGTM configuration so it is covered by that repo set.